thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default
Date Tue, 13 Mar 2018 14:26:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397011#comment-16397011
] 

ASF GitHub Bot commented on THRIFT-4474:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1479
  
    Any other php folks out there want to comment or review on the breaking change here? 
It looks like the strategy was to change the generator and provide a flag to allow folks to
generate older style code for backwards compatibility.


> PHP generator use PSR-4 default
> -------------------------------
>
>                 Key: THRIFT-4474
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4474
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Compiler
>            Reporter: Robert Lu
>            Assignee: Robert Lu
>            Priority: Major
>
> Before, PHP generator generate php files like {{Types.php}}, {{Service.php}}.
> Those can only be load via [{{classmap}}|https://getcomposer.org/doc/04-schema.md#classmap]
method. The latest PSR about autoload is [PSR-4|http://www.php-fig.org/psr/psr-4/].
> thrift compiler can generate PSR-4 code default, if want old-style code(which can only
load via classmap), add {{classmap}} option.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message