thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4419) Rust framed transport cannot handle writes above 4096 bytes
Date Sat, 17 Mar 2018 03:12:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403237#comment-16403237
] 

ASF GitHub Bot commented on THRIFT-4419:
----------------------------------------

GitHub user allengeorge opened a pull request:

    https://github.com/apache/thrift/pull/1508

    THRIFT-4419: Fix bug where framed messages > 4K could not be read

    Client: rs

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/allengeorge/thrift thrift-4419

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1508.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1508
    
----
commit f358ffbd997d33ad60bf4602c65d46ea6792386a
Author: Allen George <allen.george@...>
Date:   2017-12-13T12:34:49Z

    THRIFT-4419: Fix bug where framed messages > 4K could not be read
    Client: rs

----


> Rust framed transport cannot handle writes above 4096 bytes
> -----------------------------------------------------------
>
>                 Key: THRIFT-4419
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4419
>             Project: Thrift
>          Issue Type: Bug
>          Components: Rust - Library
>            Reporter: Allen George
>            Assignee: Allen George
>            Priority: Critical
>
> Related to THRIFT-4390
> Description copied form there:
> While working on improving test coverage and fixing busted cross tests I reworked the
cpp test client to send binary in at size 0, 1, 2, 4, 6, 16, ..., 131072 and after 4096 the
rust server gave up.
> {noformat}
> 12, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128])
> WARN:thrift::server::threaded: processor completed with error: TransportError { kind:
Unknown, message: "failed to write whole buffer" }
> Server process is successfully killed.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message