thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift issue #1491: THRIFT-4489: Add UDS support for nodejs thrift client
Date Mon, 19 Mar 2018 20:22:19 GMT
Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1491
  
    Okay so, here's the deal.  This pull request has 9 commits and one of them is a merge.
 If you want your name on the commit tag you will need to squash and resubmit with a single
commit and then I can cherry-pick it over and push it.  Otherwise if you don't care, I can
squash and merge it, but my name will end up in the "Author" field of the commit, and I will
include your name in the content of the pull request, i.e.:
    
    ```
    commit 496568e57a17889f484c6275078bef2bcb43382e (HEAD -> master)
    Author: James E. King III <jking@apache.org>
    Date:   Mon Mar 19 16:16:37 2018 -0400
    
        THRIFT-4489: Add UDS support for nodejs thrift client
        Patch: Daniel Shih <hotingwow@gmail.com>
        Client: nodejs
        
        This closes #1491
    ```
    Let me know what you want to do.  I'm fine either way.


---

Mime
View raw message