thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ozymaxx <...@git.apache.org>
Subject [GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...
Date Thu, 15 Mar 2018 06:30:20 GMT
Github user ozymaxx commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1496#discussion_r174687128
  
    --- Diff: test/py/RunClientServer.py ---
    @@ -298,7 +300,11 @@ def main():
         print('----------------')
         for genpydir in generated_dirs:
             for script in SCRIPTS:
    -            runScriptTest(options.libdir, options.gen_base, genpydir, script)
    +            # The MSVC 2013 C++ compiler stores the double literals differently from
    +            # the MSVC 2015 and G++ compilers, so the TestRenderedDoubleConstants test
    +            # fails on the VMs with the MSVC2013 configuration
    +            if not (script == 'TestRenderedDoubleConstants.py' and options.msvc_profile
== 'MSVC2013'):
    +                runScriptTest(options.libdir, options.gen_base, genpydir, script)
    --- End diff --
    
    and here @jeking3 


---

Mime
View raw message