thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...
Date Wed, 14 Mar 2018 15:15:15 GMT
Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1496#discussion_r174494320
  
    --- Diff: lib/java/gradle/unitTests.gradle ---
    @@ -68,6 +68,20 @@ test {
         include '**/Test*.class'
         exclude '**/Test*\$*.class'
     
    +    println 'Check if msvc.profile exists'
    --- End diff --
    
    It seems to me this fix is in the wrong place.  I don't like having the C++ compiler type
passed down into the java build so it can disable a test.  The compiler code be modified somehow.



---

Mime
View raw message