From dev-return-51398-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Fri Feb 2 21:01:03 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id C281C180608 for ; Fri, 2 Feb 2018 21:01:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B2536160C49; Fri, 2 Feb 2018 20:01:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 07458160C25 for ; Fri, 2 Feb 2018 21:01:02 +0100 (CET) Received: (qmail 30390 invoked by uid 500); 2 Feb 2018 20:01:02 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 30379 invoked by uid 99); 2 Feb 2018 20:01:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Feb 2018 20:01:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B06BE1A0579 for ; Fri, 2 Feb 2018 20:01:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id O5vwH07eRulc for ; Fri, 2 Feb 2018 20:01:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B70145F2A9 for ; Fri, 2 Feb 2018 20:01:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 549F8E00FC for ; Fri, 2 Feb 2018 20:01:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 12FB521E81 for ; Fri, 2 Feb 2018 20:01:00 +0000 (UTC) Date: Fri, 2 Feb 2018 20:01:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (THRIFT-4448) Golang: do something with context.Context MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350881#comment-16350881 ] ASF GitHub Bot commented on THRIFT-4448: ---------------------------------------- Github user johnboiles commented on the issue: https://github.com/apache/thrift/pull/1459 It bugged me to have a time.Sleep in the test so I wrote the retry logic :) > Golang: do something with context.Context > ----------------------------------------- > > Key: THRIFT-4448 > URL: https://issues.apache.org/jira/browse/THRIFT-4448 > Project: Thrift > Issue Type: Task > Components: Go - Library > Affects Versions: 0.11.0 > Reporter: John Boiles > Priority: Major > > PR Here: https://github.com/apache/thrift/pull/1459 > This patch wires through {{context.Context}} such that it can be used in in {{http.Request}}'s {{WithContext}} method. This allows Thrift HTTP requests to canceled or timed out via the context. > This patch breaks support for go<1.7 so it's not ready to ship, but I'm hoping to get some direction on this. When does Thrift expect to drop support of go1.7? It looks like the current solution is to duplicate files that need to use {{golang.org/x/net/context}} and add a {{// +build !go1.7}} but duplication seems unsustainable as the {{context}} package is imported more places. > Go 1.7 was released 15 August 2016. Given Golang has had significant performance improvements in most dot releases, I suspect most production services stay reasonably up to date. Here at Periscope/Twitter we're on go1.9.1, and we're a fairly large organization. -- This message was sent by Atlassian JIRA (v7.6.3#76005)