thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnboiles <...@git.apache.org>
Subject [GitHub] thrift pull request #1488: Golang -remote.go client cleanup
Date Thu, 01 Feb 2018 21:54:15 GMT
GitHub user johnboiles opened a pull request:

    https://github.com/apache/thrift/pull/1488

    Golang -remote.go client cleanup

    Several changes here related to the generated `-remote.go` clients
    
    * Serialize cli  input with TJsonProtocol since json->thrift serialization is not supported
with TSimpleJsonProtocol ([see also](https://github.com/apache/thrift/blob/19baeefd8c38d62085891d7956349601f79448b3/lib/go/thrift/simple_json_protocol.go#L335))
    * Support for http headers (allows `Authorization: TOKEN` headers to be passed in the
request)
    * Skip generation of `*-remote.go` for thrift that has no functions (they are not useful,
and fail to build since `client` is unused)
    * Support `https` urls

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/johnboiles/thrift golang-https-in-remote-client

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1488.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1488
    
----
commit 273d9404ff1eae3d3b5d76f66ac34646c9321d72
Author: John Boiles <johnaboiles@...>
Date:   2018-01-31T23:10:46Z

    golang: support https from generated clients

commit 09cc3fdd3e1041a31f6758d2ef2e40aea58061b9
Author: John Boiles <johnaboiles@...>
Date:   2018-02-01T19:06:18Z

    golang: don't generate -remote.go clients when there are no functions

commit 512eae1a61ccff83ae6d3f3a5cadee6e5e2cf7cd
Author: John Boiles <johnaboiles@...>
Date:   2018-02-01T19:32:03Z

    golang: support for http headers in -remote clients

commit 5d9365fb32c9f167265af8c1be41e14d1f02c80b
Author: John Boiles <johnaboiles@...>
Date:   2018-02-01T21:35:34Z

    golang: serialize cli requests with TJsonProtocol since serialization is not supported
with TSimpleJsonProtocol

----


---

Mime
View raw message