thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "BELUGA BEHR (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (THRIFT-4499) Remove Magic Number In TFIleTransport
Date Fri, 23 Feb 2018 22:34:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

BELUGA BEHR updated THRIFT-4499:
--------------------------------
    Attachment: THRIFT-4499.1.patch

> Remove Magic Number In TFIleTransport
> -------------------------------------
>
>                 Key: THRIFT-4499
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4499
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>    Affects Versions: 0.11.0
>            Reporter: BELUGA BEHR
>            Priority: Trivial
>         Attachments: THRIFT-4499.1.patch
>
>
> Here, the buffer is hard-coded to 8192 (which matches the default value on most JDK implementations).
You may wish to remove this magic number and let the JDK decide the size.
> https://github.com/apache/thrift/blob/19baeefd8c38d62085891d7956349601f79448b3/lib/java/src/org/apache/thrift/transport/TFileTransport.java#L369



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message