thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bo Andersen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4463) PHP generated code match PSR-2
Date Mon, 05 Feb 2018 08:16:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352125#comment-16352125
] 

Bo Andersen commented on THRIFT-4463:
-------------------------------------

Will this PR solve this issue as well:

https://github.com/allebb/netbeans-psr-formatting/issues/14 

> PHP generated code match PSR-2
> ------------------------------
>
>                 Key: THRIFT-4463
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4463
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Compiler
>    Affects Versions: 0.11.0
>            Reporter: Robert Lu
>            Assignee: Robert Lu
>            Priority: Minor
>             Fix For: 0.12.0
>
>
> When use thrift compiler to generate PHP code, there are many issues doesn't match [PSR-2|http://www.php-fig.org/psr/psr-2/]
>  * indent by 2 spaces, PSR-2 require 4 spaces.
>  * Opening brace should be on a new line (for function)
>  * The static declaration must come after the visibility declaration
>  * etc.
>  
> So, we can make generated code more readable, match PSR-2(almost).
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message