thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4448) Golang: do something with context.Context
Date Fri, 02 Feb 2018 15:26:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350515#comment-16350515
] 

ASF GitHub Bot commented on THRIFT-4448:
----------------------------------------

Github user johnboiles commented on the issue:

    https://github.com/apache/thrift/pull/1459
  
    Hmm yeah must be a race condition with the test server starting in the go routine. Any
thoughts on how to wait for it to start up? I guess I could use a wait group to wait at least
until goroutine code begins to execute. Or I could have some retry logic that tries to contact
the server for a second before failing


> Golang: do something with context.Context
> -----------------------------------------
>
>                 Key: THRIFT-4448
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4448
>             Project: Thrift
>          Issue Type: Task
>          Components: Go - Library
>    Affects Versions: 0.11.0
>            Reporter: John Boiles
>            Priority: Major
>
> PR Here: https://github.com/apache/thrift/pull/1459
> This patch wires through {{context.Context}} such that it can be used in in {{http.Request}}'s
{{WithContext}} method. This allows Thrift HTTP requests to canceled or timed out via the
context.
> This patch breaks support for go<1.7 so it's not ready to ship, but I'm hoping to
get some direction on this. When does Thrift expect to drop support of go1.7? It looks like
the current solution is to duplicate files that need to use {{golang.org/x/net/context}} and
add a {{// +build !go1.7}} but duplication seems unsustainable as the {{context}} package
is imported more places.
> Go 1.7 was released 15 August 2016. Given Golang has had significant performance improvements
in most dot releases, I suspect most production services stay reasonably up to date. Here
at Periscope/Twitter we're on go1.9.1, and we're a fairly large organization.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message