thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dcelasun <...@git.apache.org>
Subject [GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context
Date Thu, 01 Feb 2018 20:42:57 GMT
Github user dcelasun commented on the issue:

    https://github.com/apache/thrift/pull/1459
  
    I think it's worth it. The context passes through most parts of the stack and having a
test to ensure it's propagated properly feels imporant.
    
    Also, we can at least reduce the flakiness with longer timers, say 2s sleep and 1s timeout.
The test suite already takes quite a bit of time to run, an additional second should be fine.


---

Mime
View raw message