From dev-return-51029-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Fri Jan 19 18:38:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 25E9B180607 for ; Fri, 19 Jan 2018 18:38:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 15D0D160C36; Fri, 19 Jan 2018 17:38:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 598CE160C1B for ; Fri, 19 Jan 2018 18:38:03 +0100 (CET) Received: (qmail 57615 invoked by uid 500); 19 Jan 2018 17:38:02 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 57604 invoked by uid 99); 19 Jan 2018 17:38:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jan 2018 17:38:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D5252C1924 for ; Fri, 19 Jan 2018 17:38:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.711 X-Spam-Level: X-Spam-Status: No, score=-100.711 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id vzm9tHc_uf4x for ; Fri, 19 Jan 2018 17:38:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0016D5F473 for ; Fri, 19 Jan 2018 17:38:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 81815E0E04 for ; Fri, 19 Jan 2018 17:38:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 38D3221207 for ; Fri, 19 Jan 2018 17:38:00 +0000 (UTC) Date: Fri, 19 Jan 2018 17:38:00 +0000 (UTC) From: "Anton Shchyrov (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (THRIFT-4461) Invalid compiler directive MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4461?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D163= 32593#comment-16332593 ]=20 Anton Shchyrov commented on THRIFT-4461: ---------------------------------------- Full unit name System.Character. This unit added=C2=A0in Thrift.Utils by sc= heme {{uses}} {{ \{$IFDEF OLD_UNIT_NAMES}}} {{ Classes, Windows, SysUtils, *Character*, SyncObjs;}} {{ \{$ELSE}}} {{ System.Classes, Winapi.Windows, System.SysUtils, *System.Character*, Sys= tem.SyncObjs;}} {{ \{$ENDIF}}} If condition=C2=A0OLD_UNIT_NAMES is not defined then compiler will require = fully unit name. And=C2=A0identifier Character.IsLowSurrogate=C2=A0will not= be defined unlike=C2=A0identifier System.Character.IsLowSurrogate > Invalid compiler directive > -------------------------- > > Key: THRIFT-4461 > URL: https://issues.apache.org/jira/browse/THRIFT-4461 > Project: Thrift > Issue Type: Bug > Components: Delphi - Library > Affects Versions: 0.11.0 > Environment: Delphi XE3 > Reporter: Anton Shchyrov > Assignee: Jens Geyer > Priority: Minor > Labels: delphi > Attachments: Thrift.Utils.diff > > > In module=C2=A0Thrift.Utils=C2=A0daclared two methods > {{class function CharUtils.IsHighSurrogate( const c : Char) : Boolean;}} > {{begin}} > {{=C2=A0 \{$IF CompilerVersion < 23.0}}} > {{=C2=A0 result :=3D Character.IsHighSurrogate( c);}} > {{=C2=A0 \{$ELSE}}} > {{=C2=A0 result :=3D c.IsHighSurrogate();}} > {{=C2=A0 \{$IFEND}}} > {{end;}} > {{class function CharUtils.IsLowSurrogate( const c : Char) : Boolean;}} > {{begin}} > {{=C2=A0 \{$IF CompilerVersion < 23.0}}} > {{=C2=A0 result :=3D Character.IsLowSurrogate( c);}} > {{=C2=A0 \{$ELSE}}} > {{=C2=A0 result :=3D c.IsLowSurrogate;}} > {{=C2=A0 \{$IFEND}}} > {{end;}} > But methods Char.IsHighSurrogate()/Char.IsLowSurrogate()=C2=A0**appeared = in Delphi XE4. For=C2=A0Delphi XE4 variable=C2=A0CompilerVersion equal 25. > In this way condition > {{{$IF CompilerVersion < 23.0}}} > may be changed to > {{{$IF CompilerVersion < *25.0*}}} > And access for unit=C2=A0*Character* may be=C2=A0determined through defii= ne symbol=C2=A0*OLD_UNIT_NAMES* -- This message was sent by Atlassian JIRA (v7.6.3#76005)