From dev-return-50579-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Mon Jan 8 16:34:07 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 50E3618076D for ; Mon, 8 Jan 2018 16:34:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 40947160C2C; Mon, 8 Jan 2018 15:34:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 74DCB160C1E for ; Mon, 8 Jan 2018 16:34:06 +0100 (CET) Received: (qmail 19274 invoked by uid 500); 8 Jan 2018 15:34:05 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 19232 invoked by uid 99); 8 Jan 2018 15:34:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jan 2018 15:34:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2642E1808C2 for ; Mon, 8 Jan 2018 15:34:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.211 X-Spam-Level: X-Spam-Status: No, score=-108.211 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 3y8XB23o6Pky for ; Mon, 8 Jan 2018 15:34:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E58CE5FBBA for ; Mon, 8 Jan 2018 15:34:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2D592E129D for ; Mon, 8 Jan 2018 15:34:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C1FAD240FE for ; Mon, 8 Jan 2018 15:34:00 +0000 (UTC) Date: Mon, 8 Jan 2018 15:34:00 +0000 (UTC) From: "Stig Bakken (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (THRIFT-4445) PHP TSocket broken by THRIFT-4295 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stig Bakken closed THRIFT-4445. ------------------------------- Resolution: Invalid My analysis was wrong, will open a new ticket. > PHP TSocket broken by THRIFT-4295 > --------------------------------- > > Key: THRIFT-4445 > URL: https://issues.apache.org/jira/browse/THRIFT-4445 > Project: Thrift > Issue Type: Bug > Components: PHP - Library > Affects Versions: 0.11.0 > Reporter: Stig Bakken > Assignee: James E. King, III > > Thrift version 0.11.0 introduces an issue with PHP's TSocket, where it sets SO_NODELAY by default, with no way of disabling. 0.11.0 is unusable for us because of this, as we open tens or hundreds of connections per second to localhost from PHP, and with 0.11.0 we run out of client ports in a matter of seconds. > The default behaviour should be to not touch SO_NODELAY unless there is a good reason to do so! See for example https://www.extrahop.com/company/blog/2016/tcp-nodelay-nagle-quickack-best-practices/#5 -- This message was sent by Atlassian JIRA (v6.4.14#64029)