From dev-return-51293-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Tue Jan 30 04:28:28 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 5991F180654 for ; Tue, 30 Jan 2018 04:28:28 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4924D160C31; Tue, 30 Jan 2018 03:28:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 91415160C53 for ; Tue, 30 Jan 2018 04:28:27 +0100 (CET) Received: (qmail 83757 invoked by uid 500); 30 Jan 2018 03:28:26 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 83329 invoked by uid 99); 30 Jan 2018 03:28:25 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jan 2018 03:28:25 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8F416E7E99; Tue, 30 Jan 2018 03:28:25 +0000 (UTC) From: jeking3 To: dev@thrift.apache.org Reply-To: dev@thrift.apache.org References: In-Reply-To: Subject: [GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport Content-Type: text/plain Message-Id: <20180130032825.8F416E7E99@git1-us-west.apache.org> Date: Tue, 30 Jan 2018 03:28:25 +0000 (UTC) Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164632710 --- Diff: lib/php/lib/Transport/TTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use Thrift\Exception\TTransportException; --- End diff -- Why is this change needed? ---