From dev-return-51077-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Mon Jan 22 19:00:38 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 166A9180609 for ; Mon, 22 Jan 2018 19:00:38 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 06C71160C4B; Mon, 22 Jan 2018 18:00:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 446F3160C32 for ; Mon, 22 Jan 2018 19:00:37 +0100 (CET) Received: (qmail 40549 invoked by uid 500); 22 Jan 2018 18:00:36 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 40537 invoked by uid 99); 22 Jan 2018 18:00:35 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Jan 2018 18:00:35 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 68525E0A2A; Mon, 22 Jan 2018 18:00:33 +0000 (UTC) From: jeking3 To: dev@thrift.apache.org Reply-To: dev@thrift.apache.org References: In-Reply-To: Subject: [GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes Content-Type: text/plain Message-Id: <20180122180034.68525E0A2A@git1-us-west.apache.org> Date: Mon, 22 Jan 2018 18:00:33 +0000 (UTC) Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1474 In general I frown upon adding test-only values in production code (like "injected failure"). That said I see no reason for us not to incorporate these into the core. Do we really need to ask for permission to add three additional error codes from fbthrift? This may not have properly gotten every language (Common Lisp comes to mind, as it's an open PR). It's too bad we don't define the list of error codes in Thrift and then compile them for every language to use... it would ensure uniformity across languages... ---