thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default
Date Tue, 30 Jan 2018 14:46:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345134#comment-16345134
] 

ASF GitHub Bot commented on THRIFT-4474:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1479
  
    If we are making breaking changes, they need to be documented very clearly in the php/README.md
file as part of any commit.  See my breaking changes for 0.10.0 and 0.11.0 in the perl/README.md
for an example of what I mean.  I'm not certain anybody on the mailing list is listening at
this point, but if anyone has an interest in php breaking changes, you need to chime in.


> PHP generator use PSR-4 default
> -------------------------------
>
>                 Key: THRIFT-4474
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4474
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Compiler
>            Reporter: Robert Lu
>            Assignee: Robert Lu
>            Priority: Major
>
> Before, PHP generator generate php files like {{Types.php}}, {{Service.php}}.
> Those can only be load via [{{classmap}}|https://getcomposer.org/doc/04-schema.md#classmap]
method. The latest PSR about autoload is [PSR-4|http://www.php-fig.org/psr/psr-4/].
> thrift compiler can generate PSR-4 code default, if want old-style code(which can only
load via classmap), add {{classmap}} option.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message