thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Geyer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (THRIFT-4467) Add methods WriteFmt/WriteLineFmt to TThriftConsole class
Date Tue, 23 Jan 2018 20:29:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336322#comment-16336322
] 

Jens Geyer edited comment on THRIFT-4467 at 1/23/18 8:28 PM:
-------------------------------------------------------------

I don't see this patch as part of the Thrift library. The entire Console construct is basically
only a helper that was introduced as part of the initial development. Since the model was
the C# library, the original author introduced that class, very likely to reduce dependencies.
The implementation is rather raw (read: shitty), and - in the case of the real console it
is not safe against concurrent accesses. If asked, I would rather throw it out instead of
polishing it and adding features. We are dealing with RPC here, not with providing cool console
output stuff.

Long story short: I'm against it. -1

 

 


was (Author: jensg):
I don't see this patch as part of the Thrift library. The entire Console construct is basically
only a helper that was introduced as part of the initial development. Since the model was
the C# library, the original author introduced that class. The implementation is rather raw
anyways, and if asked I would throw it out instead of polishing it and add9ing features. We
are dealing with RPC here, not with providing cool console output stuff. 

Long story short: I'm against it. -1

 

 

> Add methods WriteFmt/WriteLineFmt to TThriftConsole class
> ---------------------------------------------------------
>
>                 Key: THRIFT-4467
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4467
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Delphi - Library
>    Affects Versions: 0.11.0
>            Reporter: Anton Shchyrov
>            Priority: Minor
>              Labels: Console
>
> For ease of use, add methods
> {{procedure TThriftConsole.WriteFmt(const AFmt: string;}}
>  const AArgs: array of const);
>  {{begin}}
>  {{  Write(Format(AFmt, AArgs));}}
>  {{end;}}
> {{procedure TThriftConsole.WriteLineFmt(const AFmt: string;}}
>  const AArgs: array of const);
>  {{begin}}
>  {{  WriteLine(Format(AFmt, AArgs));}}
>  {{end;}}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message