thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4464) Potentially server-crashing typo in Python TNonblockingServer
Date Wed, 24 Jan 2018 00:14:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336610#comment-16336610
] 

ASF GitHub Bot commented on THRIFT-4464:
----------------------------------------

Github user tomtung commented on the issue:

    https://github.com/apache/thrift/pull/1475
  
    Maybe @nsuke (who wrote made the change originally) can help check?


> Potentially server-crashing typo in Python TNonblockingServer
> -------------------------------------------------------------
>
>                 Key: THRIFT-4464
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4464
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.11.0
>         Environment: n/a
>            Reporter: Tom Dong
>            Priority: Major
>              Labels: EasyFix, Typo
>
> The line [https://github.com/apache/thrift/blob/bfba370bf163425823ce7b660f9d123f5fc67c79/lib/py/src/server/TNonblockingServer.py#L177] 
> {code:java}
> self._wbuf = self.message[sent:]
> {code}
>  
> But self.message is never assigned. Maybe should be
> {code:java}
> self._wbuf = self._wbuf[sent:]{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message