thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4460) php library use PSR-2
Date Mon, 22 Jan 2018 21:52:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334982#comment-16334982
] 

ASF GitHub Bot commented on THRIFT-4460:
----------------------------------------

Github user RobberPhex commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1472#discussion_r163079208
  
    --- Diff: build/docker/scripts/sca.sh ---
    @@ -49,6 +49,10 @@ flake8 --ignore=E501 test/test.py
     flake8 --ignore=E501,E722 test/crossrunner
     flake8 test/features
     
    +# PHP code style
    +composer install --quiet
    +./vendor/bin/phpcs
    --- End diff --
    
    @jeking3 
    `phpcs` will check which PHP library match PSR-2.(like `flake8`)


> php library use PSR-2
> ---------------------
>
>                 Key: THRIFT-4460
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4460
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Library
>    Affects Versions: 0.11.0
>            Reporter: Robert Lu
>            Assignee: Robert Lu
>            Priority: Minor
>
> PHP Library can use [PSR-2|http://www.php-fig.org/psr/psr-2/] as code standard



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message