thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4452) optimize Dockerfile (only onetime apt-get update)
Date Fri, 12 Jan 2018 12:59:03 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323911#comment-16323911
] 

ASF GitHub Bot commented on THRIFT-4452:
----------------------------------------

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1464#discussion_r161215273
  
    --- Diff: build/docker/ubuntu-artful/Dockerfile ---
    @@ -41,10 +43,21 @@ RUN apt-get update && \
     
     # dotnet (core)
     RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > /etc/apt/trusted.gpg.d/microsoft.gpg
&& \
    -    echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod
artful main" > /etc/apt/sources.list.d/dotnetdev.list
    +    echo "deb [arch=amd64] https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod
artful main" > \
    +    /etc/apt/sources.list.d/dotnetdev.list
    --- End diff --
    
    Indent this so it makes more sense (it looks like a separate command)


> optimize Dockerfile (only onetime apt-get update)
> -------------------------------------------------
>
>                 Key: THRIFT-4452
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4452
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Build Process
>    Affects Versions: 0.11.0
>            Reporter: Robert Lu
>            Assignee: Robert Lu
>            Priority: Minor
>
> When build [apache/thrift-build|https://github.com/apache/thrift/blob/a15060a/build/docker/ubuntu-trusty/Dockerfile],
there are many times to run apt-get update.
> We can just run one time apt-get update after add all repo.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message