thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stig Bakken (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (THRIFT-4445) PHP TSocket broken by THRIFT-4295
Date Mon, 08 Jan 2018 15:34:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stig Bakken closed THRIFT-4445.
-------------------------------
    Resolution: Invalid

My analysis was wrong, will open a new ticket.

> PHP TSocket broken by THRIFT-4295
> ---------------------------------
>
>                 Key: THRIFT-4445
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4445
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>    Affects Versions: 0.11.0
>            Reporter: Stig Bakken
>            Assignee: James E. King, III
>
> Thrift version 0.11.0 introduces an issue with PHP's TSocket, where it sets SO_NODELAY
by default, with no way of disabling. 0.11.0 is unusable for us because of this, as we open
tens or hundreds of connections per second to localhost from PHP, and with 0.11.0 we run out
of client ports in a matter of seconds.
> The default behaviour should be to not touch SO_NODELAY unless there is a good reason
to do so! See for example https://www.extrahop.com/company/blog/2016/tcp-nodelay-nagle-quickack-best-practices/#5



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message