thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process
Date Sat, 13 Jan 2018 14:36:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325149#comment-16325149
] 

ASF GitHub Bot commented on THRIFT-4434:
----------------------------------------

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1449#discussion_r161373415
  
    --- Diff: lib/netcore/Makefile.am ---
    @@ -19,86 +19,25 @@
     
     SUBDIRS = . 
     
    -THRIFT = $(top_builddir)/compiler/cpp/thrift
    -
    -TESTDIR = Tests/Thrift.PublicInterfaces.Compile.Tests
    -GENDIR = $(TESTDIR)/gen-netcore
    -
     THRIFTCODE = \
    -			Thrift/Thrift.csproj \
    --- End diff --
    
    I don't think this is correct, removing all the dependencies here.  This means if a source
code file changes but the project stays the same, make won't trigger a netcore build - it
will think the target is up to date.  In the merge I am including both, and adding three missing
source code files.  Because of this, I am going to have to submit a CI for the merge to make
sure it works.


> Update .NET Core components, add tests for .Net Core library and .Net Core compiler,
fix bugs and build process
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-4434
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4434
>             Project: Thrift
>          Issue Type: Improvement
>          Components: .NETCore - Compiler, .NETCore - Library, Build Process
>         Environment: Windows, Linux, MacOS
>            Reporter: Volodymyr Gotra
>            Assignee: Volodymyr Gotra
>            Priority: Critical
>
> This pull request should:
> - highly improve the current version of .Net Core library and .Net Core compiler and
quality of code
> - improve and simplify build process
> - improve documentation related to .Net Core library and compiler
> - fix found bugs (some of bugs can be clarified like major - they are related to porting
of protocols from Java version and can be present in C# library)
> - add important unit tests for .Net Core library and .Net Core compiler
> - add possibility to easy add unit tests for compiler for other languages



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message