thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From RobberPhex <...@git.apache.org>
Subject [GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Date Tue, 30 Jan 2018 03:40:23 GMT
Github user RobberPhex commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1484#discussion_r164633942
  
    --- Diff: lib/php/lib/Transport/TTransport.php ---
    @@ -22,6 +22,7 @@
     
     namespace Thrift\Transport;
     
    +use Thrift\Exception\TTransportException;
    --- End diff --
    
    There is doc comment `@throws TTransportException` at Line 45.
    
    No one (and IDE) knows which TTransportException.


---

Mime
View raw message