thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport
Date Tue, 30 Jan 2018 03:28:25 GMT
Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1484#discussion_r164632749
  
    --- Diff: lib/php/lib/Transport/TBufferedTransport.php ---
    @@ -78,11 +69,26 @@ public function __construct($transport = null, $rBufSize = 512, $wBufSize
= 512)
          */
         protected $rBuf_ = '';
     
    +    /**
    +     * Constructor. Creates a buffered transport around an underlying transport
    +     */
    +    public function __construct($transport, $rBufSize = 512, $wBufSize = 512)
    --- End diff --
    
    It would have been more obvious if the pull request changed only this line, removing the
"= null".


---

Mime
View raw message