thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From RobberPhex <...@git.apache.org>
Subject [GitHub] thrift pull request #1472: THRIFT-4460: PHP Library use PSR-2
Date Mon, 22 Jan 2018 21:51:33 GMT
Github user RobberPhex commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1472#discussion_r163079208
  
    --- Diff: build/docker/scripts/sca.sh ---
    @@ -49,6 +49,10 @@ flake8 --ignore=E501 test/test.py
     flake8 --ignore=E501,E722 test/crossrunner
     flake8 test/features
     
    +# PHP code style
    +composer install --quiet
    +./vendor/bin/phpcs
    --- End diff --
    
    @jeking3 
    `phpcs` will check which PHP library match PSR-2.(like `flake8`)


---

Mime
View raw message