thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vgotra <...@git.apache.org>
Subject [GitHub] thrift pull request #1449: THRIFT-4434. Update .NET Core components, add tes...
Date Sat, 13 Jan 2018 16:03:11 GMT
Github user vgotra commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1449#discussion_r161375213
  
    --- Diff: lib/netcore/Makefile.am ---
    @@ -19,86 +19,25 @@
     
     SUBDIRS = . 
     
    -THRIFT = $(top_builddir)/compiler/cpp/thrift
    -
    -TESTDIR = Tests/Thrift.PublicInterfaces.Compile.Tests
    -GENDIR = $(TESTDIR)/gen-netcore
    -
     THRIFTCODE = \
    -			Thrift/Thrift.csproj \
    --- End diff --
    
    .Net Core cli should automatically handle that - if file didn't change - it will not trigger
the build - hope this will help you to spend less time on adding every file to list (autotools
as I understand doesn't support wildcards)


---

Mime
View raw message