thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stigsb <...@git.apache.org>
Subject [GitHub] thrift pull request #1340: THRIFT-4295: reworked docker images to resolve bu...
Date Fri, 12 Jan 2018 10:46:53 GMT
Github user stigsb commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1340#discussion_r161191042
  
    --- Diff: lib/php/lib/Thrift/Transport/TSocket.php ---
    @@ -242,8 +242,10 @@ public function open()
           throw new TException($error);
         }
     
    -    $socket = socket_import_stream($this->handle_);
    -    socket_set_option($socket, SOL_TCP, TCP_NODELAY, 1);
    +    if (function_exists('socket_import_stream') && function_exists('socket_set_option'))
{
    --- End diff --
    
    My analysis was incorrect, it wasn't your patch causing our issue @jeking3 sorry for jumping
the gun.


---

Mime
View raw message