Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@thrift.apache.org
Date: Sun, 10 Dec 2017 05:30:00 +0000 (UTC)
From: "Bob Cao (JIRA)" <jira@apache.org>
To: dev@thrift.apache.org
Message-ID: <JIRA.13123088.1512535941000.425395.1512883800229@Atlassian.JIRA>
In-Reply-To: <JIRA.13123088.1512535941000@Atlassian.JIRA>
References: <JIRA.13123088.1512535941000@Atlassian.JIRA> <JIRA.13123088.1512535941292@jira-lw-us.apache.org>
Subject: [jira] [Commented] (THRIFT-4410) Extra ending underscore with field
 ending with `result` for Golang
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 10 Dec 2017 05:30:09 -0000


    [ https://issues.apache.org/jira/browse/THRIFT-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285086#comment-16285086 ] 

Bob Cao commented on THRIFT-4410:
---------------------------------

Hi [~jensg], thanks for the explanation!

I tried very hard to understand it but still can't fully comprehend. Would you mind providing a concert example where the conflicts actually rise without the underscore, under the context of thrift version 0.10.0?

That will greatly help! Thanks in advance! :)

> Extra ending underscore with field ending with `result` for Golang
> ------------------------------------------------------------------
>
>                 Key: THRIFT-4410
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4410
>             Project: Thrift
>          Issue Type: Question
>          Components: Go - Compiler
>    Affects Versions: 0.10.0
>         Environment: macos high sierra
>            Reporter: Bob Cao
>            Priority: Trivial
>
> Given a struct where fields ending with {{result}}
> {code}
> struct Test {
>     1: optional string id_result
>     2: optional string name_result
>     3: optional string full_description_result
>     4: optional string image_url_result
> }
> {code}
> The generated go codes are 
> {code:go}
> type Test struct {
>   IDResult_ *string `thrift:"id_result,1" db:"id_result" json:"id_result,omitempty"`
>   NameResult_ *string `thrift:"name_result,2" db:"name_result" json:"name_result,omitempty"`
>   FullDescriptionResult_ *string `thrift:"full_description_result,3" db:"full_description_result" json:"full_description_result,omitempty"`
>   ImageURLResult_ *string `thrift:"image_url_result,4" db:"image_url_result" json:"image_url_result,omitempty"`
> }
> {code}
> I am expecting the field has the same name as defined (no undersore at the end). 
> Thanks  [~jensg] for pointing out the codes, if anyone could en-light me about why IDL identifiers end with "Args"/"Result" interferes with the implicit service, that will be much appreciated!!


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)