Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 98059200D51 for ; Fri, 22 Dec 2017 13:53:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 96A94160C2D; Fri, 22 Dec 2017 12:53:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DAA37160BFD for ; Fri, 22 Dec 2017 13:53:04 +0100 (CET) Received: (qmail 27343 invoked by uid 500); 22 Dec 2017 12:53:04 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 27331 invoked by uid 99); 22 Dec 2017 12:53:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Dec 2017 12:53:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8F491C65AE for ; Fri, 22 Dec 2017 12:53:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 2Sha1YeFkr2P for ; Fri, 22 Dec 2017 12:53:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 997225F121 for ; Fri, 22 Dec 2017 12:53:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6054DE0DE3 for ; Fri, 22 Dec 2017 12:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8515C240FA for ; Fri, 22 Dec 2017 12:53:00 +0000 (UTC) Date: Fri, 22 Dec 2017 12:53:00 +0000 (UTC) From: "James E. King, III (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (THRIFT-4380) Compiler incorrect generates code which treats a Java enum as a binary type MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 22 Dec 2017 12:53:05 -0000 [ https://issues.apache.org/jira/browse/THRIFT-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-4380. -------------------------------------- Assignee: James E. King, III > Compiler incorrect generates code which treats a Java enum as a binary type > --------------------------------------------------------------------------- > > Key: THRIFT-4380 > URL: https://issues.apache.org/jira/browse/THRIFT-4380 > Project: Thrift > Issue Type: Bug > Components: Java - Compiler > Affects Versions: 0.10.0 > Reporter: Christopher Tubbs > Assignee: James E. King, III > > ./compiler/cpp/src/thrift/generate/t_java_generator.cc around line 4661 seems to incorrectly wrap an enum with TBaseHelper.copyBinary. This caused a build failure when building the java tutorial on s390x. > Cannot reproduce this bug on x86_64, only on s390x so far. Could use the assistance of an upstream Thrift developer to take a look at the C++ code to examine for correctness. It looks like it's trying to cast enums to a base type, and then check if it's a binary type. > Please see external tracker: https://bugzilla.redhat.com/show_bug.cgi?id=1507518 -- This message was sent by Atlassian JIRA (v6.4.14#64029)