thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Cao (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (THRIFT-4410) Extra ending underscore with field ending with `result` for Golang
Date Fri, 08 Dec 2017 03:19:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bob Cao updated THRIFT-4410:
----------------------------
    Description: 
Given a struct where fields ending with {{result}}

{code}
struct Test {
    1: optional string id_result
    2: optional string name_result
    3: optional string full_description_result
    4: optional string image_url_result
}
{code}


The generated go codes are 


{code:go}
type Test struct {
  IDResult_ *string `thrift:"id_result,1" db:"id_result" json:"id_result,omitempty"`
  NameResult_ *string `thrift:"name_result,2" db:"name_result" json:"name_result,omitempty"`
  FullDescriptionResult_ *string `thrift:"full_description_result,3" db:"full_description_result"
json:"full_description_result,omitempty"`
  ImageURLResult_ *string `thrift:"image_url_result,4" db:"image_url_result" json:"image_url_result,omitempty"`
}
{code}

I am expecting the field has the same name as defined (no undersore at the end). 

Thanks  [~jensg] for pointing out the codes, if anyone could enlight me why 





  was:
Given a struct where fields ending with {{result}}

{code}
struct Test {
    1: optional string id_result
    2: optional string name_result
    3: optional string full_description_result
    4: optional string image_url_result
}
{code}


The generated go codes are 


{code:go}
type Test struct {
  IDResult_ *string `thrift:"id_result,1" db:"id_result" json:"id_result,omitempty"`
  NameResult_ *string `thrift:"name_result,2" db:"name_result" json:"name_result,omitempty"`
  FullDescriptionResult_ *string `thrift:"full_description_result,3" db:"full_description_result"
json:"full_description_result,omitempty"`
  ImageURLResult_ *string `thrift:"image_url_result,4" db:"image_url_result" json:"image_url_result,omitempty"`
}
{code}







> Extra ending underscore with field ending with `result` for Golang
> ------------------------------------------------------------------
>
>                 Key: THRIFT-4410
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4410
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Compiler
>    Affects Versions: 0.10.0
>         Environment: macos high sierra
>            Reporter: Bob Cao
>
> Given a struct where fields ending with {{result}}
> {code}
> struct Test {
>     1: optional string id_result
>     2: optional string name_result
>     3: optional string full_description_result
>     4: optional string image_url_result
> }
> {code}
> The generated go codes are 
> {code:go}
> type Test struct {
>   IDResult_ *string `thrift:"id_result,1" db:"id_result" json:"id_result,omitempty"`
>   NameResult_ *string `thrift:"name_result,2" db:"name_result" json:"name_result,omitempty"`
>   FullDescriptionResult_ *string `thrift:"full_description_result,3" db:"full_description_result"
json:"full_description_result,omitempty"`
>   ImageURLResult_ *string `thrift:"image_url_result,4" db:"image_url_result" json:"image_url_result,omitempty"`
> }
> {code}
> I am expecting the field has the same name as defined (no undersore at the end). 
> Thanks  [~jensg] for pointing out the codes, if anyone could enlight me why 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message