thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4403) thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen
Date Mon, 04 Dec 2017 14:37:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276857#comment-16276857
] 

ASF GitHub Bot commented on THRIFT-4403:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1437
  
    Great - I am going to see if this resolves any of the cross test known failures.


> thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen
> --------------------------------------------------------------------
>
>                 Key: THRIFT-4403
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4403
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Library
>            Reporter: Philip Frank
>
> Inside the forEach callback 'this' will be the global object, not the transport object,
as the implementation seems to assume.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message