thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King, III (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (THRIFT-4099) Auto-derive Hash for generated Rust structs
Date Thu, 14 Dec 2017 13:56:13 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James E. King, III closed THRIFT-4099.
--------------------------------------

> Auto-derive Hash for generated Rust structs
> -------------------------------------------
>
>                 Key: THRIFT-4099
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4099
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Rust - Compiler
>            Reporter: Allen George
>            Assignee: James E. King, III
>            Priority: Minor
>             Fix For: 0.11.0
>
>
> Currently Thrift structs are turned into Rust {{struct}} definitions that do not have
an auto-derived {{Hash}}. We should auto-derive this trait.
> The following behaviors should be checked:
> # Can still derive {{Hash}} even if the struct contains a {{double}}
> # Can still derive {{Hash}} even if the struct contains {{set<double>}}
> # Can still derive {{Hash}} even if the struct contains {{map<double, double>}}
> Basically, doubles are represented in the auto-generated code by {{OrderedFloat}} instead
of {{f64}} since we cannot derive a hash for, or order Rust floats. The resulting code should
work even if doubles are contained any where in the structure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message