thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift pull request #1448: [WIP] Support compilation without Boost
Date Fri, 22 Dec 2017 21:03:56 GMT
Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1448#discussion_r158557742
  
    --- Diff: lib/cpp/src/thrift/processor/TMultiplexedProcessor.h ---
    @@ -165,10 +166,11 @@ class TMultiplexedProcessor : public TProcessor {
         }
     
         // Extract the service name
    -    boost::tokenizer<boost::char_separator<char> > tok(name, boost::char_separator<char>(":"));
    -
         std::vector<std::string> tokens;
    -    std::copy(tok.begin(), tok.end(), std::back_inserter(tokens));
    +    std::istringstream tokenStream(name);
    +    for (std::string token; std::getline(tokenStream, token, ':');) {
    --- End diff --
    
    getline may only be available in C++11 or later
    
    As a project should we consider calling out 0.11.0 as the last version that will support
C++03, and simplify this work?


---

Mime
View raw message