thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift pull request #1437: THRIFT-4403: Fix incorrect usage of 'this'
Date Mon, 04 Dec 2017 15:26:16 GMT
Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1437#discussion_r154679526
  
    --- Diff: lib/js/src/thrift.js ---
    @@ -599,8 +599,8 @@ Thrift.TWebSocketTransport.prototype = {
               //If the user made calls before the connection was fully
               //open, send them now
               this.send_pending.forEach(function(elem) {
    -             this.socket.send(elem.buf);
    -             this.callbacks.push((function() {
    +             self.socket.send(elem.buf);
    --- End diff --
    
    We don't run "js" through cross test right now. :|


---

Mime
View raw message