Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8E025200D4C for ; Thu, 30 Nov 2017 18:44:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8C8E8160BF6; Thu, 30 Nov 2017 17:44:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D7A52160C01 for ; Thu, 30 Nov 2017 18:44:04 +0100 (CET) Received: (qmail 68059 invoked by uid 500); 30 Nov 2017 17:44:03 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 67901 invoked by uid 99); 30 Nov 2017 17:44:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Nov 2017 17:44:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6C99D1A14C4 for ; Thu, 30 Nov 2017 17:44:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id vK8ADXWw4KEF for ; Thu, 30 Nov 2017 17:44:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 580F35F58D for ; Thu, 30 Nov 2017 17:44:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 85A2AE0EFA for ; Thu, 30 Nov 2017 17:44:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id CFDF821066 for ; Thu, 30 Nov 2017 17:44:00 +0000 (UTC) Date: Thu, 30 Nov 2017 17:44:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (THRIFT-3657) D TFileWriterTransport close should use non-priority send MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 30 Nov 2017 17:44:05 -0000 [ https://issues.apache.org/jira/browse/THRIFT-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273039#comment-16273039 ] ASF GitHub Bot commented on THRIFT-3657: ---------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1427 > D TFileWriterTransport close should use non-priority send > --------------------------------------------------------- > > Key: THRIFT-3657 > URL: https://issues.apache.org/jira/browse/THRIFT-3657 > Project: Thrift > Issue Type: Bug > Components: D - Library > Reporter: Aki Sukegawa > Assignee: Aki Sukegawa > Priority: Trivial > Fix For: 0.11.0 > > > prioritySend is used in TFileWriterTransport close method. > A possible problem with this is that even synchronized calls that are strictly before close call can be ignored in rare occasions. > The author has put a comment "FIXME: Should use normal send here" and there's no reason not to. > I suspect it is a remnant of old implementation or local debug stuff. -- This message was sent by Atlassian JIRA (v6.4.14#64029)