Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0D5DE200D34 for ; Fri, 3 Nov 2017 16:06:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0BF13160BE9; Fri, 3 Nov 2017 15:06:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 47E2F160BFB for ; Fri, 3 Nov 2017 16:06:08 +0100 (CET) Received: (qmail 12206 invoked by uid 500); 3 Nov 2017 15:06:07 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 11866 invoked by uid 99); 3 Nov 2017 15:06:07 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Nov 2017 15:06:07 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1809CDFAE4; Fri, 3 Nov 2017 15:06:07 +0000 (UTC) From: jeking3 To: dev@thrift.apache.org Reply-To: dev@thrift.apache.org References: In-Reply-To: Subject: [GitHub] thrift pull request #1382: THRIFT-4285 Move TX/RX methods from gen. code to ... Content-Type: text/plain Message-Id: <20171103150607.1809CDFAE4@git1-us-west.apache.org> Date: Fri, 3 Nov 2017 15:06:07 +0000 (UTC) archived-at: Fri, 03 Nov 2017 15:06:09 -0000 Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1382#discussion_r148808038 --- Diff: lib/go/test/tests/client_error_test.go --- @@ -411,7 +411,7 @@ func TestClientReportTTransportErrors(t *testing.T) { if !prepareClientCallReply(protocol, i, err) { return } - client := errortest.NewErrorTestClientProtocol(transport, protocol, protocol) + client := errortest.NewErrorTestClient(thrift.NewTStandardClient(protocol, protocol)) --- End diff -- Not having to change the test is a better proof that the original method works :) ---