thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4285) Pull generated send/recv into library to allow behaviour to be customised
Date Fri, 03 Nov 2017 14:36:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237666#comment-16237666
] 

ASF GitHub Bot commented on THRIFT-4285:
----------------------------------------

Github user dcelasun commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1382#discussion_r148798731
  
    --- Diff: build/docker/ubuntu-trusty/Dockerfile ---
    @@ -217,6 +217,62 @@ RUN rm -rf /var/cache/apt/* && \
         rm -rf /tmp/* && \
         rm -rf /var/tmp/*
     
    +# Ruby
    --- End diff --
    
    Fixed.


> Pull generated send/recv into library to allow behaviour to be customised
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-4285
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4285
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler, Go - Library
>            Reporter: Chris Bannister
>            Assignee: Chris Bannister
>            Priority: Major
>         Attachments: 0001-go-pull-generated-send-recv-into-lib-v6.patch, 0001-go-pull-generated-send-recv-into-lib-v7.patch
>
>
> Currently it is difficult to change how thrift writes messages onto the transport because
they are in the generated code. Instead the generated send/recv methods should be in the library.
This will greatly simplify the client code and remove many duplicate methods whilst allowing
users more flexibility to implement connection pools and other features such as THeader.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message