thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-3773) Swift Library
Date Wed, 01 Nov 2017 15:16:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234195#comment-16234195
] 

ASF GitHub Bot commented on THRIFT-3773:
----------------------------------------

Github user nsuke commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1084#discussion_r148288455
  
    --- Diff: compiler/cpp/src/thrift/generate/t_swift_generator.cc ---
    @@ -245,22 +297,30 @@ class t_swift_generator : public t_oop_generator {
      */
     void t_swift_generator::init_generator() {
       // Make output directory
    -  MKDIR(get_out_dir().c_str());
    +  string module = get_real_swift_module(program_);
    +  string out_dir = get_out_dir();
    +  string module_path = out_dir;
    +  string name = capitalize(program_name_);
    +  if (namespaced_ and !module.empty()) {
    --- End diff --
    
    I just noticed that this broke Windows build.
    It seems that VC++ does not support alternative keywords in our settings.
     Can you replace`and` with `&&` ? We'll see if it fixes the build.


> Swift Library
> -------------
>
>                 Key: THRIFT-3773
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3773
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Swift - Library
>            Reporter: Thomas Bartelmess
>            Assignee: Chris Simpson
>            Priority: Major
>
> We already have the option to generate Swift code in the Cocoa compiler, however large
parts of the (Objective-C) Cocoa Library still depend on Cocoa and  Objective-C.
> It would be good to have a native Swift library that doesn't depend on the Cocoa libraries.
> Design goals:
> - Fully compatible with the code that is currently generated by the Cocoa compiler (both
Objective-C and Swift).
> - Ability to run on Linux
> - Pure Swift, no Objective-C code.
> - No dependencies on closed source apple libraries
> - Keep the same interface, so that the library is compatible with the code the current
cocoa compiler generates
> - Better server support that the current Objective-C library.
> - Follow the new Swift packaging format to be compatible with the Swift Package manager



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message