thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-3657) D TFileWriterTransport close should use non-priority send
Date Thu, 30 Nov 2017 17:44:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273039#comment-16273039
] 

ASF GitHub Bot commented on THRIFT-3657:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1427


> D TFileWriterTransport close should use non-priority send
> ---------------------------------------------------------
>
>                 Key: THRIFT-3657
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3657
>             Project: Thrift
>          Issue Type: Bug
>          Components: D - Library
>            Reporter: Aki Sukegawa
>            Assignee: Aki Sukegawa
>            Priority: Trivial
>             Fix For: 0.11.0
>
>
> prioritySend is used in TFileWriterTransport close method.
> A possible problem with this is that even synchronized calls that are strictly before
close call can be ignored in rare occasions.
> The author has put a comment "FIXME: Should use normal send here" and there's no reason
not to.
> I suspect it is a remnant of old implementation or local debug stuff.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message