thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift issue #1418: Thrift 3877 http server buffering bug oneway
Date Wed, 29 Nov 2017 18:19:17 GMT
Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1418
  
    I think it's fine as-is, except for adding to ThriftTest in this case since that is a
global test thrift file, and you need one local to lib/cpp/test.  The fact you took the time
to add a unit test and did it in a very TDD way makes me quite happy. :)


---

Mime
View raw message