thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeking3 <...@git.apache.org>
Subject [GitHub] thrift pull request #1382: THRIFT-4285 Move TX/RX methods from gen. code to ...
Date Fri, 03 Nov 2017 15:06:07 GMT
Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1382#discussion_r148808038
  
    --- Diff: lib/go/test/tests/client_error_test.go ---
    @@ -411,7 +411,7 @@ func TestClientReportTTransportErrors(t *testing.T) {
     		if !prepareClientCallReply(protocol, i, err) {
     			return
     		}
    -		client := errortest.NewErrorTestClientProtocol(transport, protocol, protocol)
    +		client := errortest.NewErrorTestClient(thrift.NewTStandardClient(protocol, protocol))
    --- End diff --
    
    Not having to change the test is a better proof that the original method works :)


---

Mime
View raw message