Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 48267200D3B for ; Fri, 27 Oct 2017 01:46:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 46926160BF3; Thu, 26 Oct 2017 23:46:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8386F1609E5 for ; Fri, 27 Oct 2017 01:46:31 +0200 (CEST) Received: (qmail 84175 invoked by uid 500); 26 Oct 2017 23:46:30 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 84164 invoked by uid 99); 26 Oct 2017 23:46:30 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Oct 2017 23:46:30 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4CC6DDF9E6; Thu, 26 Oct 2017 23:46:30 +0000 (UTC) From: sokac To: dev@thrift.apache.org Reply-To: dev@thrift.apache.org References: In-Reply-To: Subject: [GitHub] thrift pull request #1401: THRIFT-4373: Derefer PHP zval _TSPEC Content-Type: text/plain Message-Id: <20171026234630.4CC6DDF9E6@git1-us-west.apache.org> Date: Thu, 26 Oct 2017 23:46:30 +0000 (UTC) archived-at: Thu, 26 Oct 2017 23:46:32 -0000 Github user sokac commented on a diff in the pull request: https://github.com/apache/thrift/pull/1401#discussion_r147295690 --- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp --- @@ -709,6 +715,9 @@ void binary_serialize(int8_t thrift_typeID, PHPOutputTransport& transport, zval* throw_tprotocolexception("Attempt to send non-object type as a T_STRUCT", INVALID_DATA); } zval* spec = zend_read_static_property(Z_OBJCE_P(value), "_TSPEC", sizeof("_TSPEC")-1, true); + if (spec) { --- End diff -- removed if statement ---