thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (THRIFT-4378) add set stopTimeoutUnit method to TThreadPoolServer
Date Mon, 30 Oct 2017 11:13:02 GMT


ASF GitHub Bot commented on THRIFT-4378:

GitHub user itegel opened a pull request:

    THRIFT-4378: add set method for stopTimeoutUnit in TThreadPoolServer java lib


You can merge this pull request into a Git repository by running:

    $ git pull THRIFT-4378

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1409


> add set stopTimeoutUnit method to TThreadPoolServer
> ---------------------------------------------------
>                 Key: THRIFT-4378
>                 URL:
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>         Environment: java lib
>            Reporter: itegel bao
>            Priority: Minor
> All time units all have set method, except this stopTimeoutUnit, in TThreadPoolServer.

> And for default it is se to TimeUnit.SECONDS. 
> In our projects we prefer TimeUnit.MILLISECONDS to TimeUnit.SECONDS, at least we want
it to be the same over whole project.
> So can we add a set methods for stopTimeoutUnit

This message was sent by Atlassian JIRA

View raw message