thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4378) add set stopTimeoutUnit method to TThreadPoolServer
Date Tue, 31 Oct 2017 02:20:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226129#comment-16226129
] 

ASF GitHub Bot commented on THRIFT-4378:
----------------------------------------

Github user itegel commented on the issue:

    https://github.com/apache/thrift/pull/1409
  
    Thank you! You are right ! It only works on line 218 and that is almost useless. I will
try to fix what you suggested soon.


> add set stopTimeoutUnit method to TThreadPoolServer
> ---------------------------------------------------
>
>                 Key: THRIFT-4378
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4378
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>         Environment: java lib
>            Reporter: itegel bao
>            Priority: Minor
>
> All time units all have set method, except this stopTimeoutUnit, in TThreadPoolServer.

> And for default it is se to TimeUnit.SECONDS. 
> In our projects we prefer TimeUnit.MILLISECONDS to TimeUnit.SECONDS, at least we want
it to be the same over whole project.
> So can we add a set methods for stopTimeoutUnit



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message