thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josip Sokcevic (JIRA)" <j...@apache.org>
Subject [jira] [Created] (THRIFT-4373) Extending Thrift class results in "Attempt serialize from non-Thrift object"
Date Wed, 25 Oct 2017 20:10:00 GMT
Josip Sokcevic created THRIFT-4373:
--------------------------------------

             Summary: Extending Thrift class results in "Attempt serialize from non-Thrift
object"
                 Key: THRIFT-4373
                 URL: https://issues.apache.org/jira/browse/THRIFT-4373
             Project: Thrift
          Issue Type: Bug
          Components: PHP - Library
    Affects Versions: 0.10.0
         Environment: Linux 4.13.3-1-ARCH
PHP 7.1.10
            Reporter: Josip Sokcevic


This happens when using php extension. thrift_protocol_write_binary will check Z_TYPE_P of
spec and expects to be array (IS_ARRAY). However, PHP7 will set it as reference (IS_REFERENCE).

Example:

{code}
$s = new Serializer\TBinarySerializer();

// Foo is a Thrift type class
class FooExtended extends Foo {}

$o = new Foo();
$o2 = new FooExtended();

// this works just fine:
$s->serialize($o); // this uses thrift_protocol_write_binary if available

// Next line throws \Thrift\Exception\TProtocolException if thrift_protocol_write_binary is
used
// However, it doesn't break if no extension is available.
$s->serialize($o);
{code}

Proposed solution is to dereference using ZVAL_DEREF before checking types (attached). Alternative
would be to mark struct type classes as final, but that break compatibility.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message