thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4354) TSocket block on read
Date Tue, 10 Oct 2017 02:03:01 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198031#comment-16198031
] 

Robert Lu commented on THRIFT-4354:
-----------------------------------

[~jfarrell]

I think it's a simple fix. Is there any problem?

> TSocket block on read
> ---------------------
>
>                 Key: THRIFT-4354
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4354
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>    Affects Versions: 0.9.3, 0.10.0
>         Environment: php7.0 + macOS
>            Reporter: Robert Lu
>            Assignee: Robert Lu
>
> When \Thrift\Transport\TSocket::read is called, it will block until receive $len byte([TSocket.php#L273-L276|https://github.com/apache/thrift/blob/master/lib/php/lib/Thrift/Transport/TSocket.php#L273-L276])
> But, sometimes, other call TSocket::read with large length,
> such as [TBufferedTransport|https://github.com/apache/thrift/blob/39310dad793ca69b4b7217a3b54430e682e5e2a4/lib/php/lib/Thrift/Transport/TBufferedTransport.php#L136-L138]:
> {code}
>     if (TStringFuncFactory::create()->strlen($this->rBuf_) === 0) {
>       $this->rBuf_ = $this->transport_->read($this->rBufSize_);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message