thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gideon Korir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4350) Update netcore build for dotnet 2.0 sdk and make cross validation
Date Thu, 05 Oct 2017 06:29:02 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192513#comment-16192513
] 

Gideon Korir commented on THRIFT-4350:
--------------------------------------

I've sent in a PR that upgrades the project SDK to dotnet core 2.0. The project now targets
netstandard 1.6 & 2.0. Build + tests were successful (although ruby autotools.sh is broken
in Travis) and I created a sample at [thrift aspnet core sample|https://github.com/gideonkorir/thriftnetcoresample].
I didn't change the code for now but upgrading the SDK allows for further improvements e.g.
merging it with the CSharp code base

> Update netcore build for dotnet 2.0 sdk and make cross validation
> -----------------------------------------------------------------
>
>                 Key: THRIFT-4350
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4350
>             Project: Thrift
>          Issue Type: Improvement
>          Components: .NETCore - Library
>    Affects Versions: 0.10.0
>         Environment: docker ubuntu-xenial
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>
> # Add dotnet core 2.0.0 official to the docker build image (xenial)
> # Convert projects using "dotnet migrate"
> # Ensure one can build on Windows inside Visual Studio 2017 using the project that is
checked in
> # Ensure one can build on Linux using the project that is checked in and use make check
> # Set the target framework to netcoreapp2.0 - required for threading to work?
> # Enable netcore in make cross
> # Fix issues found:
> ## netcore library never increases the sequence id number



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message