thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4037) [CMake] Use a single build system for thrift to make development easier
Date Tue, 24 Oct 2017 03:08:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216225#comment-16216225
] 

Robert Lu commented on THRIFT-4037:
-----------------------------------

Personally,

I'd like to migrate to cmake.

----

But, I haven't see any final decision.

*keep in autotools, remove cmake? or migrate to cmake, remove autotools? or keep cmake and
autotools?*

It's difficult to keep autotools *and* cmake works.

> [CMake] Use a single build system for thrift to make development easier
> -----------------------------------------------------------------------
>
>                 Key: THRIFT-4037
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4037
>             Project: Thrift
>          Issue Type: Epic
>          Components: Build Process
>    Affects Versions: 0.10.0
>         Environment: All
>            Reporter: James E. King, III
>            Assignee: James E. King, III
>            Priority: Critical
>
> h1. Background
> The thrift project currently carries two build systems.  The original build system is
based on autoconf and is used to build a complete deliverable including extensive cross-language
testing.
> The other build system was introduced a few years ago, with roots tracing back to THRIFT-797.
 CMake allows thrift to build natively on multiple platforms - unix and windows.  Autoconf
is no longer under active development with the last release in 2012, and it does not allow
for native windows builds using native tools that are used by a majority of consumers.
> Maintaining two build systems for a project incurs a lot of overhead.  Every change that
touches the build system needs to be done twice, in two completely different ways.  We need
twice as many CI jobs to verify that all of the builds are working, whereas with a single
cmake build environment we could likely use a single CI build job per platform that does everything
using the docker image on linux and appveyor on windows.
> h1. Proposal
> We should officially deprecate autoconf in favor of cmake, and continue (more aggressively)
the effort to make the cmake build environment as functional as the autoconf build environment.
 During this transition, folks will be required to make changes to both build systems (which
are proven out mostly through the Travis CI build jobs; only CMake is used on AppVeyor).
> h1. Acceptance Criteria
> # All existing platforms, targets, and tests are converted to use cmake
> ## Including cross-compilation
> # All CI builds are converted to use cmake
> # autoconf build environment is removed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message