thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-3737) Improve TSocket isOpen() implementation to give more accurate connection status.
Date Sat, 28 Oct 2017 14:57:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223558#comment-16223558
] 

ASF GitHub Bot commented on THRIFT-3737:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/945
  
    If that is the case and the change is no longer desired, we need to close this out somehow.


> Improve TSocket isOpen() implementation to give more accurate connection status.
> --------------------------------------------------------------------------------
>
>                 Key: THRIFT-3737
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3737
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>            Reporter: Cherrot Luo
>              Labels: patch
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> h2. Description
> Typically isOpen() of TSocket.py in python lib would *ALWAYS* return true, even if the
underlying TCP connection has been closed or reset by the peer, unless you manually invoke
its close() method.
> This is because the isOpen method takes a simple but kind of "irresponsible" way to judge
connection status:
> {code:title=TSocket.py}
> def isOpen(self):
>     return self.handle is not None
> {code}
> This may affect the downstream lib/tools' implementation to offer a *reliable* transport
instance. 
> For example, in [happybase|https://github.com/wbolster/happybase] (a developer-friendly
Python library to interact with Apache HBase), it use isOpen() to judge whether it neccessary
to reopen the connection in its [connection|https://github.com/wbolster/happybase/blob/9cbd718c10a3089f234f1eac1236b631e1f8e7cd/happybase/connection.py#L164]
and connection pool.
> h2. Fix
> I've sent a github [Pull Request|https://github.com/apache/thrift/pull/945]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message