thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-2987) TProtocol should return NSString directly rather than by reference to appease ARC
Date Wed, 25 Oct 2017 14:49:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218808#comment-16218808
] 

ASF GitHub Bot commented on THRIFT-2987:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/387


> TProtocol should return NSString directly rather than by reference to appease ARC
> ---------------------------------------------------------------------------------
>
>                 Key: THRIFT-2987
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2987
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Cocoa - Library
>            Reporter: Jeremy W. Sherman
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> As currently written, the compiler gripes like so:
> {code}
> thrift/lib/cocoa/src/protocol/TBinaryProtocol.m:161:55: warning: method parameter of
type 'NSString *__autoreleasing *' with no explicit ownership [-Wexplicit-ownership-type]
> - (void) readMessageBeginReturningName: (NSString **) name
>                                                       ^
> {code}
> Annotating for ownership might make non-ARC builds unhappy, but since there is only one
object being returned by reference, this and similar methods can just be changed to return
the name directly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message